mastodon.world is one of the many independent Mastodon servers you can use to participate in the fediverse.
Generic Mastodon server for anyone to use.

Server stats:

9.6K
active users

#codereview

4 posts4 participants0 posts today

I am so fucking tired of arguing with people on why PR/commit descriptions are important.

You saving the 30-90 seconds from writing one costs so much more down the road from reviewers to gaining historical context.

Ok, so you didn't include one. No worries, get it next time. Now then arguing that you don't need it makes my fucking infuriated.

Also don't use AI here. I don't care what the PR is. I want to know why you coded they way you did. Whats the context. 2 sentences goes a long fucking way

I've on many occasion said I hate some word or phrase, but I don't think I've ever truly meant it, until "vibe coding".

A large part of my work is code reviews. I'm now seeing an increasing amount of influence from AI generated tripe.

It might be speeding up someone else's job, but mine just became much harder, challenging and time consuming, since I now have to go through the code twice as thoroughly.

Fuck AI.

Working on some #code written by an #intern a few years ago and it's taking all of my energy to just add the feature and not refactor the whole thing. What's the point of having an intern and not reviewing their code as they go to prevent these issues? So verbose, so much duplication 😡😡

I guess I've been writing tools all by myself here with no review either, hopefully whoever takes them over eventually feels like I designed them reasonably 🤷

#Gitbutler now has it's own review system (compatible with GH PRs) from the creator of GH PRs.

blog.gitbutler.com/gitbutlers-

So yet another external review system showing how broken #githubs PR system really is.

We now have #ReviewStack (does anyone actually use this), Graphite, and GitButler in the Github compatible alternate review system along with the client side systems (#jj, #ghstacks, #sapling, et al)

However I think GitButler totally misses the mark and continues the the sins of PRs into thinking that you need to groups PRs together into a logic unit.

Phabricator and Gerrit have both supported stacking diffs and the power of stacking was that a change could be related to a feature (i.e building up to implementing it) or just dependent on other features in the stack.

Forcing that a "branch" is has to be a single feature and your commits are reviewable but you still can't stack branches is STILL a hurdle to productivity which is the entire point.

Also no command line for gitbutler makes it my least favorite by far.

GitButler · GitButler's new patch based Code Review (Beta)Introducing Butler Review, a new commit-based, chat centered code review tool, now in beta.